-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix flow interface imports giving false-negative with named
rule
#881
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
This fixes import-js#708 without ignoring all type imports.
No idea on that travis-ci error, seems unrelated to the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reran the travis build; seems like a fluke.
It just needs a merge now, right ? ;) |
published with 2.6.1 👍🏻 thanks! |
Looks like I'm still experiencing this issue in 2.7.0 with redux flow-typed definitions. |
@athomann we are seeing it also, but it may be a different issue (possibly #616 ?) since To expound on that - for us, this works with flow but results in
but this works and results in no eslint error
EDIT: opened this issue as #927 EDIT 2: We are also still experiencing the original issue with flow-typed defs |
This fixes #708 without ignoring all type imports.