Skip to content

Fix flow interface imports giving false-negative with named rule #881

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

futpib
Copy link
Contributor

@futpib futpib commented Jun 23, 2017

This fixes #708 without ignoring all type imports.

@coveralls
Copy link

coveralls commented Jun 23, 2017

Coverage Status

Coverage remained the same at 95.963% when pulling 9a06426 on futpib:named-flow-import-interface into 8101d39 on benmosher:master.

@futpib
Copy link
Contributor Author

futpib commented Jun 23, 2017

No idea on that travis-ci error, seems unrelated to the changes in this PR.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reran the travis build; seems like a fluke.

@julienw
Copy link

julienw commented Jun 28, 2017

It just needs a merge now, right ? ;)

@ljharb ljharb merged commit 4d561e3 into import-js:master Jun 28, 2017
@benmosher
Copy link
Member

published with 2.6.1 👍🏻 thanks!

@athomann
Copy link

athomann commented Jul 6, 2017

Looks like I'm still experiencing this issue in 2.7.0 with redux flow-typed definitions.

@SpainTrain
Copy link

SpainTrain commented Sep 13, 2017

@athomann we are seeing it also, but it may be a different issue (possibly #616 ?) since redux-form >= 7 exports flow defs from the module itself.

To expound on that - for us, this works with flow but results in named error from eslint-plugin-import

import type {FormProps} from 'redux-form'

but this works and results in no eslint error

import type {FormProps} from 'redux-form/es/index.js.flow'

EDIT: opened this issue as #927

EDIT 2: We are also still experiencing the original issue with flow-typed defs

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

False positives when importing from flow-typed module declarations
7 participants