[1/4] We finally got Google to fix the import issue

[WillsterJohnson]

see this comment

After months of asking, Google have finally taken an interest in shipping code that is valid for execution. They've added .js extensions to their imports! Let's congratulate Google's engineers on implementing what they were taught on day one of their JavaScript education.

I'm not sure if this repo fixes anything else they got wrong, but I've only seen this repo in reference to the imports issue. If that's all this repo fixes, and of course if you trust Google to maintain the use of valid JavaScript, it may be best to direct this lib's users back upstream with a depreaction notice.

[kwaa]

The problem still exists. material-foundation/material-color-utilities#79

I tried it locally (pnpm workspace) and it prevented me from installing @material/material-color-utilities.

I'll deprecate this fork - once upstream is fully available, but obviously not yet. so keep the issue open and keep track of news...

[kwaa]

I'm not sure if this repo fixes anything else they got wrong

The main differences between this repo and the upstream are:

• unbuild
  • cjs support
  • detailed exports and files
    • as you can see, upstream exported all unnecessary .ts files
• fix onerrorcontainer in dark mode #39
  • Problems with on-error-container tone value in dark mode material-foundation/material-color-utilities#62
• there is no pointless postinstall, which avoids the above installation problems

[WillsterJohnson]

Let's see if we can get rid of the pointless postinstall... material-foundation#81
Can't believe Google engineers can't write JavaScript packages.

[kwaa]

I really can't understand why upstream doesn't accept external contributions. Maybe I should consider making some bigger changes (and external contributions are warmly welcome).

[rodydavis]

Please keep in mind the code of conduct on these issues.

We are not accepting upstream at the moment but can make the changes internally. Just added lots of changes from related issues.

[kwaa]

We are not accepting upstream at the moment but can make the changes internally. Just added lots of changes from related issues.

Apparently upstream was slow to react. Still doesn't work until latest 0.2.1: I have a question, did they never install this package via npm?

[rodydavis]

No we usually depend via sub module.

But it will be fixed on 0.2.2 (change is pending internally and will get pushed out)

[kwaa]

Deprecated! Replaced by mcu-extra, which no longer needs to be synchronized with upstream updates.