Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixing Material Foundation's TypeScript Color Utilities Library (again) #81

Closed
wants to merge 3 commits into from

Conversation

WillsterJohnson
Copy link

Fixes #79

TODO list;

  • reduce bulk and excess
  • don't run build scripts when users install a package
  • ensure build works
  • ensure tests pass
  • teach the world-class engineers at Google (a globally known houshold name) how package.json works

@WillsterJohnson
Copy link
Author

Hello again. I'm back, and very upset that I (a 20-year old Uni student) have to come along yet again to fix the glaringly obvious bugs in code written by the world-class engineers at Google.
I don't deserve to write code anywhere close to anything you write, much less be the one to come by and fix the issues in your code. You work at Google for #@$& sake folks, how am I fixing your code?

See you all in approximately 500 days when this issue is resolved.

Best, Willster.

@rodydavis
Copy link
Member

Thank you for the change, there is some context for why we had this in the package.json but due to changes in how we publish it was no longer needed.

This comment is incredibly rude and against our code of conduct, and keep in mind all comments made on open source repos are available forever.

In the future please comment with respect and constructive feedback. These repos require work to open source and get working properly.

@WillsterJohnson
Copy link
Author

My apologies for my rudeness.
I hope you can understand the frustration I feel though, as the Material Design System is something I find to be as close to perfection as possible, and yet using it is blocked by simple issues like this. My frustration is not meant to be directed at any of your team, just generally at Google due to their long-standing pattern of "make something amazing then under-support it's progression".
I am very grateful for the work done by the material foundation, especially for open sourcing this library and continuing to support fixes and improvments.

@rodydavis
Copy link
Member

Latest code is pushed to main, working on publishing to npm

@WillsterJohnson WillsterJohnson closed this by deleting the head repository Mar 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript utils won't install with the new version ( 0.2.1 )
2 participants