Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support Chinese in impressConsole #774

Merged
merged 2 commits into from
Oct 11, 2020
Merged

Support Chinese in impressConsole #774

merged 2 commits into from
Oct 11, 2020

Conversation

kdxcxs
Copy link
Contributor

@kdxcxs kdxcxs commented Oct 10, 2020

No description provided.

@henrikingo
Copy link
Member

Why not all three?

case zh:
case zh-cn:
case zh-CN:
    ...

@kdxcxs
Copy link
Contributor Author

kdxcxs commented Oct 10, 2020

Cause it's just simplified Chinese,considering the existence of traditional Chinese,I think it's better like that.

@henrikingo henrikingo merged commit d0c427f into impress:master Oct 11, 2020
@henrikingo
Copy link
Member

Thanks. This is a cool addition of a major language!

@kdxcxs
Copy link
Contributor Author

kdxcxs commented Oct 11, 2020

My pleasure

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdxcxs @henrikingo