Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow to include vertex info via format option system #131

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

HDembinski
Copy link
Collaborator

The Root writer does not write the vertex info by default to save disk space. It was foreseen to optionally save the vertex info, but a configuration option was missing.

I now added a configuration system for the output format. You can now provide options to the format via colon, e.g. format:option1:option2[...]. Currently, there are two formats which accept options.

  • hepmc accepts gz, e.g. you can pass hepmc and hepmc:gz
  • root accepts vertex, e.g. you can pass root and root:vertex

@HDembinski
Copy link
Collaborator Author

The Windows failure is not related to this change, but because we hit the download limit, also see #132

Copy link
Member

@afedynitch afedynitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Windows test failed because of download limit, so feel free to merge.

@HDembinski HDembinski merged commit 63f6155 into main Feb 17, 2023
@HDembinski HDembinski deleted the cli_include_vertex branch February 17, 2023 12:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants