Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

DISCUSSION: Backend #4

Open
wer-mathurin opened this issue Nov 17, 2022 · 3 comments
Open

DISCUSSION: Backend #4

wer-mathurin opened this issue Nov 17, 2022 · 3 comments

Comments

@wer-mathurin
Copy link

@imsamgarg
have you evaluated the potential of using ISAR as a backend for storing the cached Images?
@imsamgarg
Copy link
Owner

Do you mean, for the web?

@wer-mathurin
Copy link
Author

wer-mathurin commented Nov 17, 2022 via email

@imsamgarg
Copy link
Owner

I think it would be overkill for such a small project.

bartdelange added a commit to bartdelange/firebase_cached_image_equality_check_fix that referenced this issue May 4, 2023
@bartdelange
Removing covariant in the == override
933fa82 
Using covariant in this way disallows us to switch between image providers.
This is because DecorationImage and the like use an equals check on their image provider.

As shown in error below, which was thrown when switching between an asset image and the firebase image: 

======== Exception caught by widgets library =======================================================
The following _TypeError was thrown building Builder(dirty, dependencies: [Directionality, MediaQuery, _LocalizationsScope-[GlobalKey#61773]]):
type 'AssetImage' is not a subtype of type 'FirebaseImageProvider' of 'other'

The relevant error-causing widget was: 
  Ink Ink:file:///anon/lib/components/widget.dart:100:28
When the exception was thrown, this was the stack: 
#0      FirebaseImageProvider.== (package:firebase_cached_image/src/firebase_image_provider.dart)
#1      DecorationImage.== (package:flutter/src/painting/decoration_image.dart:196:24)
imsamgarg#2      BoxDecoration.== (package:flutter/src/painting/box_decoration.dart:329:24)
imsamgarg#3      InkDecoration.decoration= (package:flutter/src/material/ink_decoration.dart:355:15)
imsamgarg#4      _InkState._build (package:flutter/src/material/ink_decoration.dart:292:13)
imsamgarg#5      Builder.build (package:flutter/src/widgets/basic.dart:7448:48)
imsamgarg#6      StatelessElement.build (package:flutter/src/widgets/framework.dart:5038:49)
imsamgarg#7      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4968:15)
@bartdelange bartdelange mentioned this issue May 4, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imsamgarg @wer-mathurin