Ensure checked-in RAL is consistent with generated RAL #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gen-ral job - ensures that imxrtral.py works - ensures that the Makefile works - ensures that the user hasn't commited RAL changes that aren't described in imxrtral.py The job will generate the RAL over the existing RAL. We check git to see if anything changes. If there are untracked changes, we fail the job.
Default Makefile behavior will compile all of the crates. We're just interested in checking consistency with what's auto-generated, since successful builds will be checked by separate jobs. Create a new 'ci' Makefile target that does everything 'all' does, except checking the Rust code.
mciantyre
changed the title
teburd
approved these changes
Jun 30, 2020
mitchmindtree
added a commit
to mitchmindtree/teensy4-rs
that referenced
this pull request
Jul 1, 2020
As of imxrt-rs/imxrt-hal#67 and imxrt-rs/imxrt-hal#68 the `ral` workaround is no longer necessary. As of imxrt-rs/imxrt-hal#69 `Peripherals::steal` is available on the master branch.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to enable git dependencies and lower the bar for contribution. See #65 for more information.
The PR builds on #67. To ensure the checked-in RAL code is consistent with what is auto-generated, we add a new CI job,
gen-ral, which will generate the RAL and check for any file differences. If users are correctly modifying the RAL by editing theimxrtral.pyscript, there should be no file differences between what is checked in and what is generated. But, if the user manually modifies a RAL source file, and it's not reflected inimxrtral.py, the job fails.Note that this PR targets the
check-in-ralbranch, which is described by #67. If accepted, we should also feel comfortable accepting #67.Testing
gen-raljob failed