Skip to content

Commit

Permalink
[SECURITY] Prevent information disclosure of records
Browse files Browse the repository at this point in the history
With a crafted url for the confirmation action, it was
possible to reveal form data of already persisted emails.

This behavior is mitigated with a check, whether the email
was already persisted or not.  If it is already persisted,
the request ist forwarded to the main form.
  • Loading branch information
mschwemer committed Aug 2, 2024
1 parent c376df2 commit 0617567
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Classes/Controller/FormController.php
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ public function initializeConfirmationAction(): void
*/
public function confirmationAction(Mail $mail): void
{
if ($mail->getUid() !== null) {
$this->forward('form');
}
$this->signalDispatch(__CLASS__, __FUNCTION__ . 'BeforeRenderView', [$mail, $this]);
/** @noinspection PhpUnhandledExceptionInspection */
$this->dataProcessorRunner->callDataProcessors(
Expand Down

0 comments on commit 0617567

Please # to comment.