Create sumo_entities_handler #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,6 @@ | |||
| {elvis_style, nesting_level, #{level => 3}}, | |||
| {elvis_style, god_modules, #{limit => 35}}, | |||
| {elvis_style, no_if_expression}, | |||
| {elvis_style, invalid_dynamic_call}, | |||
There was a problem hiding this comment.
Wouldn't adding the exception for the specific module be better?
There was a problem hiding this comment.
Almost all modules (at least those with actual code, i.e. not just behaviour definitions) in this repo will use dynamic calls… it's kinda the point here :)
| -spec encode_date(calendar:datetime()) -> binary(). | ||
| encode_date(DateTime) -> iso8601:format(DateTime). | ||
|
|
||
| -spec decode_date(binary()) -> calendar:datetime(). |
There was a problem hiding this comment.
According to Dialyzer:
Invalid type specification for function sr_json:decode_date/1. The success typing is (nonempty_string()) -> {{non_neg_integer(),1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12,1..255},{byte(),byte(),byte()}}
igaray
added a commit
that referenced
this pull request
Nov 18, 2015
…_handler Create sumo_entities_handler
elbrujohalcon
deleted the
elbrujohalcon.3.create_sumo_entities_handler
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has to be built on trails and it has to provide the following endpoints:
GET /[entities]- return all entitiesPOST /[entities]- creates a new entity