List mnesia as dependency of test application #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An OTP release using mnesia sumo_db adapter must list mnesia as a dependency - either in one of the applications of the OTP release or in the rebar.config - because neither [sumo_rest](https://github.com/inaka/sumo_rest/blob/0.3.3/src/sumo_rest.app.src) (of course) nor [sumo_db](https://github.com/inaka/sumo_db/blob/0.7.1/src/sumo_db.app.src) depend on mnesia. It makes sense that sumo_db does not depend on mnesia, as its users do not necessarily use the included mnesia adapter. As the test application does not have its own rebar.config, list mnesia as dependency of the application sr_test so that novice sumo_db user is reminded to list it.
|
If the sr_test application were meant to have a structure approach for building it as an OTP release, its building and startup could be tested as part of CI. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to commit message for details.
I understand the sr_test application does not have a structured way for building it as an OTP release e.g. its own rebar.config. I expect that if application sr_test were built as an OTP release without listing mnesia in rebar.config then the OTP release would fail to start for missing mnesia.