-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Modal: Property 'closeModal' does not exist #79
Labels
bug
Something isn't working
Comments
Hey @mrcnski! Thanks for submitting the issue and providing a plausible solution, I really appreciate it 😊 I'll implement a fix when I've got the time for it! |
@mrcnski I apologize that this is taking so long, I've been preoccupied with other projects. I'll try and look into it next week! 🙂 |
Thanks for the update and no worries! I just copied the component into my own project and fixed it there. |
markteekman
added a commit
that referenced
this issue
Apr 22, 2024
markteekman
added a commit
that referenced
this issue
Apr 22, 2024
Use correct `close` method on `window` #79
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Thanks for the useful resource! I noticed that
astro check
throws the following error:I believe it should simply be
window.close
. See also https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/close.The text was updated successfully, but these errors were encountered: