Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use serde_derive via derive feature on serde #333

Conversation

waywardmonkeys
Copy link
Contributor

This is the recommended way to do this in the serde docs.

This is the recommended way to do this in the `serde` docs.
@waywardmonkeys
Copy link
Contributor Author

This is for the dev dependency only, so won't impact dependent crates of indexmap, so it won't run afoul of serde-rs/serde#2584

@cuviper
Copy link
Member

cuviper commented Jul 26, 2024

As you note by that issue, that recommendation is being reconsidered. I don't see any point in changing here -- what would we be fixing by doing so?

@waywardmonkeys
Copy link
Contributor Author

I think best to close this!

@waywardmonkeys waywardmonkeys deleted the use-serive-derive-via-feature branch July 26, 2024 17:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants