Add trait MutableKeys #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove get_pair, and rename get_pair_index to get_full. Same with the mutable variant. - Move mutable key methods to MutableKeys -- we want this feature to be out of the way, but opt-in. The trait has mutable key-versions of get_full and retain
|
cc @garro95 github code search found you as a user of mutable keys. As a head's up, ordermap is preparing some small remodeling to put mutable key methods on a trait, so that users opt in to a "nonstandard" interface. Expected to be in ordermap 0.3 (or if the crate renames, there will be a bigger PSA). |
Also return the index, hence the name full
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove get_pair, and rename get_pair_index to get_full. Same with the
mutable variant.
Move mutable key methods to MutableKeys -- we want this feature to be
out of the way, but opt-in. The trait has mutable key-versions of
get_full and retain
Fixes #7