Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added support for Asm labels #54

Merged
merged 1 commit into from
Aug 16, 2020
Merged

Added support for Asm labels #54

merged 1 commit into from
Aug 16, 2020

Conversation

t11230
Copy link
Contributor

@t11230 t11230 commented Aug 15, 2020

  • Fixed superclass for ArrayDeclExt
  • Added some spaces for readability to _generate_type
  • Moved templated rules into _AsmAndAttributesMixin

@t11230
Copy link
Contributor Author

t11230 commented Aug 15, 2020

This should resolve #33

@inducer
Copy link
Owner

inducer commented Aug 15, 2020

This has some conflicts now. Could you resolve those?

@inducer
Copy link
Owner

inducer commented Aug 15, 2020

Thanks for working on this! Changes LGTM. Ready to go in once the conflicts are resolved.

- Fixed superclass for ArrayDeclExt
- Added some spaces for readability to _generate_type
- Moved templated rules into _AsmAndAttributesMixin
@inducer inducer merged commit 361679a into inducer:master Aug 16, 2020
@inducer
Copy link
Owner

inducer commented Aug 16, 2020

Thanks!

DCNick3 added a commit to DCNick3/pycparserext that referenced this pull request May 29, 2021
- Add support for declarations like `int (* __attribute__((stdcall)) fptr)(void)`
- Fix regression introduced in inducer#54, which caused function pointer information to be discarded in case any attributes or asm labels were present
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants