Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add and fix some more ruff rules #772

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Conversation

alexfikl
Copy link
Contributor

@alexfikl alexfikl commented Jul 2, 2024

Was playing around with more rules to see what's in there.

This adds flake8-logging-format, pyupgrade and the builtin ruff rules to the mix. The RUF rules were the most annoying to fix, but most of them seemed reasonable. A lot of

[1.0] + my_list -> [1.0, *my_list]

@alexfikl alexfikl marked this pull request as draft July 2, 2024 16:22
@alexfikl alexfikl marked this pull request as ready for review July 2, 2024 16:55
@alexfikl
Copy link
Contributor Author

alexfikl commented Jul 2, 2024

This should be good now. The failure in cibuildwheel seems to be because some server is down:

Could not retrieve mirrorlist http://mirrorlist.centos.org/?release=7&arch=x86_64&repo=os&infra=container

EDIT: Seems like that needs a bump in the action: https://github.com/pypa/cibuildwheel/releases/tag/v2.19.2

EDIT: Well, that fixed that issue, but now it's complaining about something else :(

@alexfikl
Copy link
Contributor Author

alexfikl commented Jul 2, 2024

@inducer That seems to have fixed it! Thanks for the help 😁

@inducer inducer merged commit c5150d5 into inducer:main Jul 2, 2024
17 checks passed
@inducer
Copy link
Owner

inducer commented Jul 2, 2024

Thx!

@alexfikl alexfikl deleted the more-ruff branch July 2, 2024 20:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants