FI-1471 Resume Location #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jammjammjamm
approved these changes
Mar 1, 2022
arscan
force-pushed
the
fi-1471-resume-location
branch
from
96414d2 to
7547594
Compare
arscan
force-pushed
the
fi-1471-resume-location
branch
from
7547594 to
c13e5f4
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our g10 tests, the user will almost never run the test from the group in which the wait/resume happens (exception is the 'other' launches), because it is embedded under a 'run_as_group' group. In the current behavior, this causes the user to get stranded at a level in the UI that shouldn't ever be accessed for this particular set of tests.
See #115
This update makes it so the user is redirected to the level in which they ran the test (could be suite, or group). To try it out, run the 'Standalone Patient App' group in the g10 tests (see the
Gemfilefor how to get those tests showing up ininferno-core). You should be redirected back to theStandalone Patient Appgroup. If you run all tests at the suite level, you should get redirected back to the suite level.This may not be quite perfect in every case, but it is substantially better in the g10 case, and still better in most cases.