FI-2053: Fix inputs dialog overflow #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
==========================================
- Coverage 77.09% 77.09% -0.01%
==========================================
Files 213 213
Lines 10461 10476 +15
Branches 966 968 +2
==========================================
+ Hits 8065 8076 +11
- Misses 1832 1834 +2
- Partials 564 566 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
bmath10
approved these changes
Aug 14, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes input dialog horizontal overflow issues: markdown scrolling in descriptions, JSON/YAML newlines and autowrapping, horizontal scrollbars
Testing Guidance
Test on g(10) Multi-Patient Auth -- run tests and in the inputs, horizontal scrollbar should no longer appear. Switching to YAML should also no longer break lines unnecessarily.