Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FI-2094: Improve tooltip a11y #386

Merged
merged 6 commits into from
Aug 25, 2023
Merged

FI-2094: Improve tooltip a11y #386

merged 6 commits into from
Aug 25, 2023

Conversation

AlyssaWang
Copy link
Contributor

Summary

  • Added tooltips to all icons without text except in report view
  • Made all such icons focusable
  • Updated snackbar styles

Testing Guidance

Are there places where additional tooltip support could be added? Places where tooltip indicators would be helpful?

Notes

  • Report view has custom pointer behavior that prevents tooltips on hover, they are still accessible via keyboard tab through

@AlyssaWang AlyssaWang requested review from arscan and mrnosal August 23, 2023 18:35
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 65.90% and project coverage change: -0.15% ⚠️

Comparison is base (b680f84) 77.10% compared to head (f4ee922) 76.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
- Coverage   77.10%   76.96%   -0.15%     
==========================================
  Files         213      213              
  Lines       10510    10573      +63     
  Branches      969      972       +3     
==========================================
+ Hits         8104     8137      +33     
- Misses       1839     1867      +28     
- Partials      567      569       +2     
Flag Coverage Δ
backend 94.51% <ø> (ø)
frontend 69.62% <65.90%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...mponents/RequestDetailModal/RequestDetailModal.tsx 84.44% <0.00%> (-0.75%) ⬇️
...mponents/TestSuite/TestSuiteDetails/ResultIcon.tsx 47.22% <45.45%> (-4.11%) ⬇️
client/src/components/App/App.tsx 55.55% <81.25%> (-3.02%) ⬇️
...ite/TestSuiteDetails/TestListItem/TestListItem.tsx 69.42% <87.50%> (+0.78%) ⬆️
...uite/TestSuiteDetails/TestListItem/RequestList.tsx 76.54% <90.00%> (+0.29%) ⬆️
client/src/components/Header/Header.tsx 78.47% <100.00%> (+1.09%) ⬆️
...iteDetails/TestGroupListItem/TestGroupListItem.tsx 71.62% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mrnosal mrnosal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tooltips visible and navigable via keyboard.

@AlyssaWang AlyssaWang closed this Aug 25, 2023
@AlyssaWang AlyssaWang reopened this Aug 25, 2023
@AlyssaWang AlyssaWang merged commit 13db9cb into main Aug 25, 2023
@AlyssaWang AlyssaWang deleted the FI-2094-tooltip-a11y branch August 25, 2023 23:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants