FI-2041: Custom suites with no ids now throw standard error #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original bug: a critical error would result when running custom test suites with either a) a blank id field (e.g., id = '') b) no id field and the console output did not provide meaningful information to the source of the error. These conditions are now checked for and will throw a standard error with a specific message upon startup
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
==========================================
- Coverage 76.95% 76.95% -0.01%
==========================================
Files 213 213
Lines 10594 10597 +3
Branches 976 978 +2
==========================================
+ Hits 8153 8155 +2
- Misses 1872 1873 +1
Partials 569 569
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Co-authored-by: Stephen MacVicar <Jammjammjamm@users.noreply.github.com>
Jammjammjamm
approved these changes
Aug 31, 2023
Jammjammjamm
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Original bug: a critical error would result when initializing Inferno with custom test suites that either:
a) had a blank id field (e.g., id = '')
b) had no id field
The console output did not provide meaningful information to the source of the error.
JIRA ticket link
These conditions are now checked for and, if present, will throw a standard error with a specific message during startup.
To reproduce: in
inferno-core>dev_suites>demo_suite.rb, edit line 7 with theidfield to be an empty string or comment out the line entirely. Then run inferno per the README instructions.Testing Guidance
None