Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FI-3710: Auth info fixes #602

Merged
merged 12 commits into from
Feb 12, 2025
Merged

FI-3710: Auth info fixes #602

merged 12 commits into from
Feb 12, 2025

Conversation

Jammjammjamm
Copy link
Collaborator

Summary

This branch adds helper methods to make it easier to use AuthInfo, and also updates how inputs are merged so that individual AuthInfo components are merged rather than being clobbered when two AuthInfo inputs are merged.

Testing Guidance

These changes are best viewed when using the g10/us core/smart app launch AuthInfo update branches.

@Jammjammjamm Jammjammjamm self-assigned this Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 82.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 84.72%. Comparing base (c722314) to head (ac81cbe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/inferno/dsl/auth_info.rb 52.17% 11 Missing ⚠️
lib/inferno/repositories/session_data.rb 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (82.85%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
- Coverage   84.74%   84.72%   -0.02%     
==========================================
  Files         283      283              
  Lines       12350    12415      +65     
  Branches     1478     1503      +25     
==========================================
+ Hits        10466    10519      +53     
- Misses       1876     1888      +12     
  Partials        8        8              
Flag Coverage Δ
backend 92.32% <82.85%> (-0.14%) ⬇️
frontend 79.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jammjammjamm Jammjammjamm merged commit 9e06950 into main Feb 12, 2025
9 of 10 checks passed
@Jammjammjamm Jammjammjamm deleted the auth-info-fixes branch February 12, 2025 13:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants