Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FI-3487: Fix response content types #616

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

Jammjammjamm
Copy link
Collaborator

Summary

This branch fixes some JSON API responses which didn't have a JSON content-type. It also fixes the content-type in a few other routes.

Testing Guidance

Open the network tab in your browser inspector. On main, you will see that the responses to some api requests have a content-type of plain or octet-stream. On this branch, the responses should all have correct content types.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.71%. Comparing base (3074d02) to head (da72be8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/inferno/apps/web/router.rb 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #616   +/-   ##
=======================================
  Coverage   84.70%   84.71%           
=======================================
  Files         283      283           
  Lines       12398    12401    +3     
  Branches     1503     1503           
=======================================
+ Hits        10502    10505    +3     
  Misses       1888     1888           
  Partials        8        8           
Flag Coverage Δ
backend 92.33% <88.88%> (+<0.01%) ⬆️
frontend 79.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jammjammjamm Jammjammjamm force-pushed the fi-3487-fix-content-type branch from 3add668 to da72be8 Compare February 14, 2025 18:57
@Jammjammjamm Jammjammjamm merged commit 9571dff into main Feb 14, 2025
9 of 10 checks passed
@Jammjammjamm Jammjammjamm deleted the fi-3487-fix-content-type branch February 14, 2025 19:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants