FI-3018: Allow multi-line custom headers in token introspection request #77
Conversation
| Ex: 'Authorization: Basic czZCaGRSa3F0MzpnWDFmQmF0M2JW' | ||
| Create an array of header name and value strings. | ||
| Ex: | ||
| [ |
There was a problem hiding this comment.
I really don't like that the tester has to create a JSON array when I imagine the most common use case is a single header. I think I would probably prefer them to just be newline delimited just like they are in an actual HTTP request.
… inserted in JSON array
| description: 'The complete URL of the token introspection endpoint.' | ||
|
|
||
| input :custom_authorization_header, | ||
| title: 'HTTP Authorization Header for Introspection Request', | ||
| input :custom_token_introspection_request_headers, |
There was a problem hiding this comment.
We don't want to change this id because that would be a breaking change.
There was a problem hiding this comment.
I also created a PR to update the id of this input in the (g)(10) test kit, but if there are multiple places that this is used and it's better just not to change this id, I will change back the id name and delete the (g)(10) pull request. Would you prefer that?
There was a problem hiding this comment.
Yes, I would prefer not to change this id.
| Ex: 'Authorization: Basic czZCaGRSa3F0MzpnWDFmQmF0M2JW' | ||
| Add custom headers for the introspection request by adding each header's name and value with a new line | ||
| between each header. | ||
| Ex: |
There was a problem hiding this comment.
This does not appear how you want it to in the UI.
…t this time to make it match description
Summary
Updated the custom_authorization_header input to parse out more than one line of input. Changed input to
custom_token introspection_request_headerinstead ofcustom_authorization_headerand updated the description of the input to be generic instead of specific to the authorization header.Testing Guidance
Run the test kit locally and ensure including headers as input in this format:
Works as expected.