Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[#385] Duplicate field definition error when @ProtoField methods over… #386

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[#385] Duplicate field definition error when @ProtoField methods over… #386

merged 1 commit into from
Jan 7, 2025

Conversation

ryanemerson
Copy link
Contributor

Closes #385

@ryanemerson ryanemerson requested a review from a team as a code owner December 13, 2024 15:13
@ryanemerson ryanemerson force-pushed the 385/field_inheritance branch from 12097ed to b319dff Compare December 17, 2024 17:18
@tristantarrant tristantarrant merged commit 6399029 into infinispan:main Jan 7, 2025
4 checks passed
@tristantarrant
Copy link
Member

Merged, thanks

@tristantarrant
Copy link
Member

Weird, CI was green, but now I cannot compile locally:

[ERROR] /home/tst/Work/Infinispan/protostream/processor/src/test/java/org/infinispan/protostream/annotations/impl/processor/tests/ProtoSchemaTest.java:[178,37] cannot find symbol
  symbol:   class ParentClassSCIImpl
  location: class org.infinispan.protostream.annotations.impl.processor.tests.ProtoSchemaTest
[ERROR] /home/tst/Work/Infinispan/protostream/processor/src/test/java/org/infinispan/protostream/annotations/impl/processor/tests/ProtoSchemaTest.java:[182,37] cannot find symbol
  symbol:   class ChildClassSCIImpl

@tristantarrant
Copy link
Member

tristantarrant commented Jan 7, 2025 •
edited
Loading

Ah, it appears it's an issue with JDK 23+

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tristantarrant tristantarrant Awaiting requested review from tristantarrant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate field definition error when @ProtoField methods overridden
2 participants
@ryanemerson @tristantarrant