refs #154 Moved Mix.env to config #159
Conversation
| @@ -37,7 +37,7 @@ defmodule Thesis.Notifications do | |||
| "other" => [] | |||
| } | |||
| |> notifications_from_host_app(conn, notifications()) | |||
| |> notifications_regarding_env(Mix.env) | |||
| |> notifications_regarding_env(Application.get_env(:thesis, :env)) | |||
There was a problem hiding this comment.
Should we fall back to Mix.env if this doesn't exist? For backwards compatibility.
There was a problem hiding this comment.
Hi! According to this topic: https://elixirforum.com/t/mix-env-in-production-no-longer-produces-nil-but-crashes-mix-state-genserver/16165/6
we shouldn't user Mix in production environment and since version 1.7.2 Mix is not included in compiled application.
And if we haven't this variable in config file Application.get_env just returns nil:
https://hexdocs.pm/elixir/Application.html#get_env/3
So we shouldn't fallback to Mix.env
P.S. before 1.7.2 Mix.env returns nil in production :)
|
Thanks @Balt87 ! I'll release a new version to Hex soon! |
|
Pushed to Hex as 0.3.3: https://github.com/infinitered/thesis-phoenix/releases/tag/v0.3.3 |
No description provided.