This repository has been archived by the owner on Mar 10, 2021. It is now read-only.
Max length requirements for pages per issue #31 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that's ok.. How will Thesis handle a default meta title/description that is hardcoded? For example, yesterday, I didn't have the thesis meta tags added yet, but it would still detect the hardcoded one that was longer than 255 chars with whitespace - it would err when i tried saving a block. @jamonholmgren |
|
Closing, because I will just expand the title/description limits to 512 and 1024 respectively in #35 . |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discuss: should we limit size of title and descriptions? For SEO benefits, this is a good idea, I think.
cc @yulianglukhenko