Fix lookup API to return data based on the country #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be able to use it in the construction of the URL.
jabou
requested changes
Dec 16, 2024
| @@ -88,30 +88,42 @@ extension PrinceOfVersions { | |||
|
|
|||
| If parameter `notificationFrequency` is set to `.always` and latest version of the app is bigger than installed version, method will always return `.newUpdateAvailable`. However, if the`notificationFrequency` is set to `.once`, only first time this method is called for the same latest app version, it will return `.newUpdateAvailable`, each subsequent call, it will return `.noUpdateAvailable`. | |||
|
|
|||
| If the optional `country` parameter is provided, the API request will target the specified App Store region (e.g., `"no"` for Norway). If `country` is not provided, the API will fallback to its default behavior, typically fetching data from the U.S. App Store. | |||
There was a problem hiding this comment.
Let's put a little easter egg in here :) :)
Set country example to hr (Croatia) or mk (Macedonia), you pick :)
| - Parameters: | ||
| * bundle: Bundle where .plist file is stored in which app identifier and app versions should be checked. | ||
| * trackPhaseRelease: Boolean that indicates whether PoV should notify about new version after 7 days when app is fully rolled out or immediately. Default value is `YES`. | ||
| * callbackQueue: The queue on which the completion handler is dispatched. By default, `main` queue is used. | ||
| * notificationFrequency: Determines update status appearance frequency. | ||
| * country: Optional parameter to specify the App Store region to target (e.g., `"no"` for Norway). Defaults to `nil`. |
| @@ -111,11 +111,14 @@ public extension PrinceOfVersions { | |||
|
|
|||
| If parameter `notificationFrequency` is set to `.always` and latest version of the app is bigger than installed version, method will always return `.newUpdateAvailable`. However, if the`notificationFrequency` is set to `.once`, only first time this method is called for the same latest app version, it will return `.newUpdateAvailable`, each subsequent call, it will return `.noUpdateAvailable`. | |||
|
|
|||
| If the optional `country` parameter is provided, the API request will target the specified App Store region (e.g., `"no"` for Norway). If `country` is not provided, the API will fallback to its default behavior, typically fetching data from the U.S. App Store. | |||
There was a problem hiding this comment.
Find all occurrences of "no" (Norway) and change it with hr/mk :)
Comment on lines
146
to
151
| var urlString = "https://itunes.apple.com/lookup?bundleId=\(bundleIdentifier)" | ||
|
|
||
| // Append the country parameter if provided | ||
| if let country = country { | ||
| urlString += "&country=\(country)" | ||
| } |
There was a problem hiding this comment.
Let's use URL components for this, so do this instead:
guard
let bundleIdentifier = bundle.bundleIdentifier,
var url = URL(string: "https://itunes.apple.com/lookup")
else {
callbackQueue.async {
completion(Result.failure(PoVError.invalidJsonData))
}
return nil
}
let queryItems: [URLQueryItem] = [
URLQueryItem(name: "bundleId", value: bundleIdentifier),
URLQueryItem(name: "country", value: country)
].filter { $0.value != nil }
url.append(queryItems: queryItems)There was a problem hiding this comment.
I like the suggested change.
I just changed the url.append(queryItems: queryItems) since it is supported from iOS 16.0+.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The App Store Lookup API defaults to the U.S. store (country=us) if no country parameter is specified. If your app isn't available in the U.S. store, this would result in an empty response.
By appending country in the URL, the API will query the country store, where your app is available, thus returning the expected data.