Skip to content

chore: workaround exponential planning time bug in DF fork #55

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

alamb
Copy link
Collaborator

@alamb alamb commented Feb 3, 2025

Targets https://github.com/influxdata/influxdb_iox/pull/13448

As @wiedld mentions in #54 (comment):

The upstream code has been changed so our previous revert can't be applied cleanly

This PR reverts the behavior with a different patch (copy/paste the old code from apache#12562)

Locally when I run the following command without this fix, it fails (timesout)

$ RUST_BACKTRACE=1 TEST_INFLUXDB_JDBC=true TEST_INTEGRATION=1 TEST_INFLUXDB_IOX_CATALOG_DSN=postgresql://postgres@localhost:5432/postgres cargo test --test  end_to_end --  read_filter_many_tables

When I have this fix it passes

running 1 test
test end_to_end_cases::querier::influxrpc::read_filter::read_filter_many_tables ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 478 filtered out; finished in 9.67s

@alamb alamb force-pushed the iox-13280/upgrade-df-ver45 branch 2 times, most recently from 48fc4f0 to 3e65898 Compare February 3, 2025 19:48
@@ -3552,134 +3574,6 @@ mod tests {
.run()
}

#[test]
fn test_union_equivalence_properties_constants_fill_gaps() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are tests of the reverted behavior so I removed them in this commit

@alamb alamb marked this pull request as ready for review February 3, 2025 19:49
@alamb
Copy link
Collaborator Author

alamb commented Feb 3, 2025

I expect clippy to fail due to the arrow 54.1 release -- I expect it till be fixed with the actual datafusion 45 release (as I will port this PR):

@wiedld wiedld force-pushed the iox-13280/upgrade-df-ver45 branch from 1353531 to 6405b35 Compare February 4, 2025 16:21
@alamb
Copy link
Collaborator Author

alamb commented Feb 5, 2025

This was included in #54

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants