Update scrollbars package dependency #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavarius
approved these changes
Jun 6, 2019
| @@ -14,6 +14,10 @@ $dapper-scrollbars--size: 6px; | |||
| bottom: 0 !important; | |||
| } | |||
|
|
|||
| .dapper-scrollbars--content { | |||
| display: block !important; | |||
There was a problem hiding this comment.
There seems to be a lot of !important in dapper scrollbars. Could this possibly be done instead with specificity?
There was a problem hiding this comment.
Yeah it's a little smelly. I'm currently using it to override the injected inline styles. Though I think in this new version I may not have to do so many !importants
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134
react-scrollbars-customto latest (no longer in alpha)autosizedefault tofalseTested all 3 components that use
DapperScrollbarsand they all work as expected