Port & Refactor ResourceList component family from InfluxDB #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavarius
approved these changes
Jun 25, 2019
| /** Placeholder text to display in input during editing */ | ||
| placeholder: string | ||
| /** Called when user hits enter or blurs the input */ | ||
| onUpdate: (description: string) => void |
There was a problem hiding this comment.
We need a provision for list items with static descriptions that shouldn’t be edited.
| private get children(): JSX.Element | ReactNode { | ||
| const {children, emptyState} = this.props | ||
|
|
||
| if (React.Children.count(children) === 0 || children === undefined) { |
There was a problem hiding this comment.
Children could also likely be null.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156
Changes
ResourceListcomponent folder from InfluxDBResourceList(means of listing and filtering cards)ResourceCard(card and related components)ownerandupdatedin favor of usingmetaDatapropResourceNameLabelcomponent did not useStandardPropsScreenshots
Checklist
changelog.mdwith link to PRNew Issues
Found this bug #160 along the way