Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Build improvements #190

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Build improvements #190

merged 1 commit into from
Jul 25, 2019

Conversation

chnn
Copy link
Contributor

@chnn chnn commented Jul 25, 2019

  • Replace microbundle with rollup (microbundle has issues transpiling some modern JS due to its dependency on buble)

  • Remove built docs artifacts from repo and instead publish them on the gh-pages branch using storybook-deployer

  • Replace npm with yarn (for consistency across projects)

  • Change publish workflow to publish straight from master with prechecks, adding a commit + tag for each release (see updated PUBLISHING.md)

  • Add rules to .npmignore

  • Replace node-sass with dart-sass, which does not require native extensions to work (can be more reliably installed on platforms besides macOS)

  • Fix duplicate CSS rules (Investigate duplicate Sass rules influxdb#13725). This reduces the build CSS size from ~339KB to ~95KB

  • Set up CircleCI to run ESLint/tsc/Prettier on PRs (we can add Jest/Chromatic if you want)

@chnn chnn force-pushed the build-stuff branch 3 times, most recently from 1d1da97 to 5450b5e Compare July 25, 2019 16:52
@chnn chnn marked this pull request as ready for review July 25, 2019 16:58
@chnn chnn requested review from mavarius and alexpaxton July 25, 2019 16:58
Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chnn chnn merged commit c6e5154 into master Jul 25, 2019
@chnn chnn deleted the build-stuff branch July 25, 2019 18:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants