Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: port and refactor CardSelect component from InfluxDB #229

Merged
merged 7 commits into from
Aug 15, 2019
Merged

feat: port and refactor CardSelect component from InfluxDB #229

merged 7 commits into from
Aug 15, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Aug 14, 2019 •
edited
Loading

Closes #174

Changes

  • Rename component to SelectableCard
  • Factor out ProtoboardIcon so any image could be passed in
  • Refactor to offer customizable size, color, and icon
  • Center text in the card when no image element is passed in

Screenshots

Screen Shot 2019-08-14 at 3 54 33 PM
Screen Shot 2019-08-14 at 3 54 57 PM
Screen Shot 2019-08-14 at 3 55 03 PM

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from a team August 14, 2019 22:55
@ghost ghost requested review from ebb-tide and removed request for a team August 14, 2019 22:55
ebb-tide
ebb-tide approved these changes Aug 15, 2019
View reviewed changes
Copy link

@ebb-tide ebb-tide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@alexpaxton alexpaxton merged commit 9c2e759 into master Aug 15, 2019
@alexpaxton alexpaxton deleted the port/card-select branch August 15, 2019 17:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ebb-tide ebb-tide ebb-tide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port card select from InfluxDB
2 participants
@alexpaxton @ebb-tide