feat: upgrade page components #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
alexpaxton
commented
Aug 29, 2019
| .cf-page-header--fluid, | ||
| .cf-page-header--fixed, | ||
| .cf-page-contents__fluid, | ||
| .cf-page-contents__fixed { |
There was a problem hiding this comment.
Goal was to use consistent naming between page header and page contents
alexpaxton
commented
Aug 29, 2019
| padding: $cf-marg-b; | ||
| } | ||
| .cf-page-contents__no-scroll { | ||
| display: flex; |
There was a problem hiding this comment.
This small change makes it way easier to have "full height" pages like the DE
121watts
approved these changes
Aug 30, 2019
Co-Authored-By: Andrew Watkins <watts@influxdb.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #253
Closes #147
Changes
PageHeaderandPageContentsmargins line up verticallyPageHeaderandPageContentsPagecomponentsPage,AppWrapper, andNavMenu(Breaking)Screenshots
Checklist
Check all that apply