Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

docs: add markdown docs for NavMenu components #256

Merged
merged 4 commits into from
Aug 30, 2019
Merged

docs: add markdown docs for NavMenu components #256

merged 4 commits into from
Aug 30, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Aug 30, 2019 •
edited
Loading

Closes #145

Changes

  • Add markdown documentation for all NavMenu components

Screenshots

Screen Shot 2019-08-30 at 9 50 06 AM

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

alexpaxton
alexpaxton commented Aug 30, 2019
View reviewed changes
.storybook/Story.scss
@@ -460,6 +460,10 @@ body.sb-show-main {
background-color: transparent;
}
}

pre + pre {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reduces the vertical gap between adjacent code samples, feels little tighter and more legible

mavarius
mavarius approved these changes Aug 30, 2019
View reviewed changes
Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@alexpaxton alexpaxton merged commit 32affd5 into master Aug 30, 2019
@alexpaxton alexpaxton deleted the docs/nav-components branch August 30, 2019 17:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mavarius mavarius mavarius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add markdown docs for Navigation components
2 participants
@alexpaxton @mavarius