Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: make all panel sub-components independently size-able #268

Merged
merged 2 commits into from
Sep 10, 2019
Merged

refactor: make all panel sub-components independently size-able #268

merged 2 commits into from
Sep 10, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Sep 10, 2019 •
edited
Loading

Closes #247

Changes

  • BREAKING Remove size prop from Panel
  • Add size prop to PanelHeader, PanelBody, PanelFooter, and PanelTitle
  • Use DismissButton component instead of custom dismiss button

Screenshots

updated-panel-sizing

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from a team September 10, 2019 19:57
@ghost ghost requested review from ebb-tide and removed request for a team September 10, 2019 19:57
@alexpaxton alexpaxton requested review from 121watts and removed request for ebb-tide September 10, 2019 19:58
@alexpaxton alexpaxton merged commit cc4858c into master Sep 10, 2019
@alexpaxton alexpaxton deleted the fix/panel-headers branch September 10, 2019 20:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@121watts 121watts 121watts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default Sizes for Panel Header Titles
2 participants
@alexpaxton @121watts