Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Introduce QuestionMarkTooltip #274

Merged
merged 9 commits into from
Sep 12, 2019
Merged

Introduce QuestionMarkTooltip #274

merged 9 commits into from
Sep 12, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Sep 12, 2019

Closes #266

Changes

  • Create a composed version of Popover called QuestionMarkTooltip
  • Split StandardProps into StandardClassProps and StandardFunctionProps
    • Did this because default props are handled differently and this is a temporary fix
  • Add callback props onShow and onHide to Popover
  • Organize folder structure for popover components

Screenshots

Screen Shot 2019-09-12 at 10 21 03 AM
question-mark-tooltip

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from a team September 12, 2019 17:23
@ghost ghost requested review from ebb-tide and removed request for a team September 12, 2019 17:23
Copy link

@ebb-tide ebb-tide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pr makes things much "class"ier.. !

@@ -3,21 +3,21 @@ import React, {Component, createRef, MouseEvent, RefObject} from 'react'
import classnames from 'classnames'

// Components
import {ClickOutside} from '../ClickOutside/ClickOutside'
import {ClickOutside} from '../../ClickOutside/ClickOutside'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relative addresses scare me a bit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am looking into setting up absolute paths but I have no idea how to configure builds

@alexpaxton alexpaxton merged commit 667aa68 into master Sep 12, 2019
@alexpaxton alexpaxton deleted the feat/question-tooltip branch September 12, 2019 18:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Composed Question Mark Tooltip Popover
2 participants