Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: convert Dropdowns to FunctionComponent and wrap with forwardRef #315

Merged
merged 21 commits into from
Oct 1, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Sep 30, 2019

Closes #291

Changes

  • Organize /Dropdowns folder:
    • Create /Documentation for docs related files
    • Create /index.tsx for family rollup class
    • Move Dropdowns/Family contents into /Dropdown
  • Convert all family and composed components to FunctionComponent and wrap with forwardRef
  • Create and export prop and ref types for all dropdown components
  • Add ref logger widget to stories for all dropdown components
  • [Breaking] remove widthPixels prop from Dropdown, SelectDropdown, and MultiSelectDropdown in favor of a default value for the style prop

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from mavarius September 30, 2019 02:05
@alexpaxton
Copy link
Contributor Author

I did not add a ref for DropdownButton since it consumes ButtonBase which does not yet have a ref. Waiting on #285 before merging

Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@alexpaxton alexpaxton merged commit 266ddca into master Oct 1, 2019
@alexpaxton alexpaxton deleted the refactor/dropdown-function-ref branch October 1, 2019 00:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Refs - Dropdowns
2 participants