Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Convert Table to FunctionComponent and wrap with forwardRef #318

Merged
merged 8 commits into from
Oct 2, 2019
Merged

Convert Table to FunctionComponent and wrap with forwardRef #318

merged 8 commits into from
Oct 2, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Sep 30, 2019 •
edited
Loading

Closes #310

Changes

  • Convert all Table components to FunctionComponent
  • Wrap each component in forwardRef
  • Add ref logger to Table docs

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton changed the title Refactor/table function ref Convert Table to FunctionComponent and wrap with forwardRef Sep 30, 2019
@alexpaxton alexpaxton requested a review from mavarius September 30, 2019 23:29
mavarius
mavarius approved these changes Sep 30, 2019
View reviewed changes
Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

src/Components/Table/Documentation/Table.stories.tsx
const tableCellRef: RefObject<TableCellRef> = createRef()
const tableFooterRef: RefObject<TableFooterRef> = createRef()

const logRefs = (): void => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should make a utility for this since we're using it in all the stories.

@alexpaxton alexpaxton merged commit 62f1043 into master Oct 2, 2019
@alexpaxton alexpaxton deleted the refactor/table-function-ref branch October 2, 2019 18:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mavarius mavarius mavarius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose Refs - Table
2 participants
@alexpaxton @mavarius