-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Convert Overlay to FunctionComponent and expose ref #329
Conversation
|
||
& > .cf-overlay--mask { | ||
width: 100% !important; | ||
height: 100% !important; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this is just for displaying this component by itself within storybook
"@types/d3-ease": "^1.0.8", | ||
"d3-ease": "^1.0.5", | ||
"react-spring": "^8.0.27" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react-spring
did not come with any easing functions out of the box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go. Are we replacing these with Panel
at a later time then?
@mavarius yeah I think I'll make that a separate issue |
Closes #301
Closes #102
Changes
FunctionComponent
wrapped withforwardRef
Overlay
to use a library calledreact-spring
to handle animationsChecklist
Check all that apply