Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Convert Overlay to FunctionComponent and expose ref #329

Merged
merged 12 commits into from
Oct 14, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Oct 14, 2019

Closes #301
Closes #102

Changes

  • Convert all overlay components to FunctionComponent wrapped with forwardRef
  • Refactor Overlay to use a library called react-spring to handle animations

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

Comment on lines +205 to +209

& > .cf-overlay--mask {
width: 100% !important;
height: 100% !important;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this is just for displaying this component by itself within storybook

Comment on lines +97 to +99
"@types/d3-ease": "^1.0.8",
"d3-ease": "^1.0.5",
"react-spring": "^8.0.27"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-spring did not come with any easing functions out of the box

@alexpaxton alexpaxton requested a review from mavarius October 14, 2019 18:55
Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Are we replacing these with Panel at a later time then?

@alexpaxton
Copy link
Contributor Author

@mavarius yeah I think I'll make that a separate issue

@alexpaxton alexpaxton merged commit bcbe24d into master Oct 14, 2019
@alexpaxton alexpaxton deleted the refactor/overlay-function-ref branch October 14, 2019 22:08
@alexpaxton
Copy link
Contributor Author

#332

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Refs - Overlay Use react-spring library for animating mount/unmount of overlays
2 participants