Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor TextArea #352

Merged
merged 10 commits into from
Oct 24, 2019
Merged

Refactor TextArea #352

merged 10 commits into from
Oct 24, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Oct 24, 2019 •
edited
Loading

Closes #351
Closes #143

Changes

  • Extract out StatusIndicator from Input so it can be used in both Input and TextArea
  • Create a set of "input" style variables that both Input and TextArea can share
  • Ensure TextArea is making use of its Size prop
  • Redesign error state to be more muted when not focused
  • Redesign hover state to have greater contrast
  • Fixes a bit (indirectly) that was causing TextArea to have a the same fixed height as Input

Screenshots

Screen Shot 2019-10-24 at 1 23 35 PM
new-input-hover-styles

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from mavarius October 24, 2019 20:42
mavarius
mavarius approved these changes Oct 24, 2019
View reviewed changes
Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to componentize the StatusIndicator.

@alexpaxton alexpaxton merged commit cff9ad2 into master Oct 24, 2019
@alexpaxton alexpaxton deleted the refactor/text-area branch October 24, 2019 22:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mavarius mavarius mavarius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextArea height is being overridden by size prop Add markdown docs for input components
2 participants
@alexpaxton @mavarius