Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remediate Storybook Addons #363

Merged
merged 3 commits into from
Oct 30, 2019
Merged

Remediate Storybook Addons #363

merged 3 commits into from
Oct 30, 2019

Conversation

mavarius
Copy link
Collaborator

@mavarius mavarius commented Oct 30, 2019

Closes #357

Changes

  • Remove @dump247/storybook-state dependency
    • Replace plugin state with the useState hook now native in storybook 5.2.x
  • Remove storybook-addon-jsx dependency
  • Update Storybook dependency to 5.2.5
  • Move d3-ease and react-spring to dev dependencies
  • Update react-docgen-typescript-loader dependency to speed up Storybook build
  • Remove unnecessary react-docgen-typescript-webpack-plugin
  • Update eslint to speed up tests
  • Remove --skipLibCheck flag

Checklist

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved

@mavarius mavarius requested a review from alexpaxton October 30, 2019 00:49
Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent improvements

@@ -186,7 +169,9 @@ draggableResizerExamplesStories.add(

draggableResizerExamplesStories.add(
'4 Panels',
withState(fourPanelsInitialState)(({store}) => {
() => {
const [positions, updatePositions] = useState<number[]>([0.25, 0.5, 0.75])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so tight!

@mavarius mavarius merged commit e1b2ad6 into master Oct 30, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook state addon causing trouble
2 participants