Fix Popover Nested Scrolling #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
desa and
zoesteinkamp
and removed request for
a team
desa
approved these changes
Oct 30, 2019
| const hidePopoverWhenOutOfView = ( | ||
| entries: IntersectionObserverEntry[] | ||
| ): void => { | ||
| if (!entries.length) { |
There was a problem hiding this comment.
Super nit-picky, but I think this function could be simplified to be
if (!!entries.length && entries[0].isIntersecting === false ) {
onHide()
}| useLayoutEffect((): (() => void) => { | ||
| handleUpdateStyles() | ||
| window.addEventListener('scroll', handleUpdateStyles) | ||
| observer.observe(triggerRef.current) | ||
| window.addEventListener('scroll', handleUpdateStyles, true) |
There was a problem hiding this comment.
Took me a whole day to figure out, but scroll events do not bubble by default. Adding this third argument in forces them to bubble
| window.addEventListener('resize', handleUpdateStyles) | ||
|
|
||
| return (): void => { | ||
| observer.disconnect() |
There was a problem hiding this comment.
Might not be necessary, but I threw it in there so the observer stops observing as a sort of "cleanup"
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #364
Changes
PopoverDialoguses to maintain position to allow event bubblingPopovercombined withDapperScrollbarsIntersectionObserverto hidePopoverwhen its trigger scrolls out of viewScreenshots
Checklist
Check all that apply