Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update RangeSlider #389

Merged
merged 7 commits into from
Nov 12, 2019
Merged

Update RangeSlider #389

merged 7 commits into from
Nov 12, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Nov 12, 2019 •
edited by TCL735
Loading

Closes #380

Changes

  • Move labels inside slider rectangle
  • Make label font size change with size prop
  • Remove orientation prop (was not doing anything)
  • Change appearance of focus and hover state to be aligned with other inputs
  • Rename some classes:
    • .cf-range-slider--wrapper --> .cf-range-slider
    • .cf-range-slider--container --> .cf-range-slider--input

Screenshots

updated-slider
range-slider-prefix-suffix

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from a team November 12, 2019 16:41
@ghost ghost requested review from desa and TCL735 and removed request for a team November 12, 2019 16:41
@alexpaxton alexpaxton merged commit 294284a into master Nov 12, 2019
@alexpaxton alexpaxton deleted the update-range-slider-labels branch November 12, 2019 17:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@TCL735 TCL735 TCL735 approved these changes

@desa desa Awaiting requested review from desa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slider labels inside of the panel
2 participants
@alexpaxton @TCL735