Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Introduce NumberedPanel component #391

Merged
merged 8 commits into from
Nov 13, 2019
Merged

Introduce NumberedPanel component #391

merged 8 commits into from
Nov 13, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Nov 12, 2019 •
edited
Loading

Closes #388

Changes

  • Create composed variant of Panel with a number and slightly modified padding called NumberedPanel
  • Works as a replacement for Panel but should use the same children elements

Screenshots

Screen Shot 2019-11-12 at 5 00 52 PM

numbered-panel

numbered-panel-responsive

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from a team November 12, 2019 22:11
@ghost ghost requested review from hoorayimhelping and zoesteinkamp and removed request for a team November 12, 2019 22:11
zoesteinkamp
zoesteinkamp approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@zoesteinkamp zoesteinkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to have a new component!

@alexpaxton alexpaxton merged commit b2d1ee0 into master Nov 13, 2019
@alexpaxton alexpaxton deleted the numbered-panels branch November 13, 2019 22:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@zoesteinkamp zoesteinkamp zoesteinkamp approved these changes

@hoorayimhelping hoorayimhelping Awaiting requested review from hoorayimhelping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create numbered panel
2 participants
@alexpaxton @zoesteinkamp