Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve NavMenu contrast #396

Merged
merged 7 commits into from
Nov 15, 2019
Merged

Improve NavMenu contrast #396

merged 7 commits into from
Nov 15, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Nov 14, 2019

Changes

  • Slightly improve nav menu contrast by darkening the purples used 1 increment

Screenshots

Screen Shot 2019-11-14 at 2 49 11 PM

Screen Shot 2019-11-14 at 2 48 59 PM

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from mavarius November 14, 2019 21:02
Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@@ -31,6 +31,7 @@

+ .clockface--app-wrapper {
top: $height + ($padding * 2);
height: calc(100% - #{$height + ($padding * 2)});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@@ -334,12 +334,22 @@
font-size: ceil($nav-menu--size * 0.4222);
}

.cf-nav--item:first-child & {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devil's in the details

@alexpaxton alexpaxton merged commit 5e55322 into master Nov 15, 2019
@alexpaxton alexpaxton deleted the improve-nav-contrast branch November 15, 2019 00:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants