Toggle input #397
Merged
Toggle input #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to make this a more generic descriptor so it can be used intiutively on more components than just Popover
Serves as an abstraction of both radio and checkbox inputs
ghost
requested review from
asalem1 and
ebb-tide
and removed request for
a team
ebb-tide
approved these changes
Nov 18, 2019
| @@ -188,7 +188,7 @@ buttonComposedStories.add( | |||
| ] | |||
| } | |||
| popoverType={ | |||
| PopoverType[select('popoverType', mapEnumKeys(PopoverType), 'Solid')] | |||
| Appearance[select('popoverType', mapEnumKeys(Appearance), 'Solid')] | |||
There was a problem hiding this comment.
I'm finding popoverType= Appearance[...] a little confusing :(
There was a problem hiding this comment.
I could rename the popoverType prop to appearance for ease of use
| @@ -21,7 +22,7 @@ import { | |||
|
|
|||
| // Notes | |||
| import SlideToggleReadme from './SlideToggle.md' | |||
| import SlideToggleLabelReadme from './SlideToggleLabel.md' | |||
| // import SlideToggleLabelReadme from './SlideToggleLabel.md' | |||
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #387
Rather than create a large checkbox specifically for the # flow, I decided to create a more generic and customizable "toggle" component. Although the
Inputcomponent currently supports acheckboxtype I did not want to add more complexity to its API.While I would suggest to anyone building a form to use the new
Togglecomponent, I did not remove support forInputType.CheckboxwithinInputto prevent breaking changesChanges
Togglecomponent that supports html "radio" and "checkbox" inputsOutlineorSolidviaAppearanceIconFontsizeandcolorcan be customized (Largesize will work for the # checkbox)PopoverTypeinto the more genericAppearance<SlideToggle.Label />into a more discreet<InputLabel />htmlForandtabIndexprops toInputLabelso they can be configured for keyboard usageScreenshots
Checklist
Check all that apply