Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace NumberedPanel with Bullet and PanelSymbolHeader #409

Merged
merged 4 commits into from
Nov 21, 2019
Merged

Replace NumberedPanel with Bullet and PanelSymbolHeader #409

merged 4 commits into from
Nov 21, 2019

Conversation

mavarius
Copy link
Collaborator

@mavarius mavarius commented Nov 21, 2019 •
edited by alexpaxton
Loading

Closes #406

Changes

  • Remove NumberedPanel component
  • Add Bullet component
  • Add PanelSymbolHeader component

Screenshots

image
image

Checklist

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved

@mavarius mavarius changed the title Add Bullet and PanelSymbolHeader Replace NumberedPanel with Bullet and PanelSymbolHeader Nov 21, 2019
@mavarius mavarius requested a review from alexpaxton November 21, 2019 00:58
alexpaxton
alexpaxton approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, excited to get this in. Only real feedback is to rebase and move the changelog entries under the 1.1.0 that is in master

@mavarius mavarius merged commit 78f1781 into master Nov 21, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexpaxton alexpaxton alexpaxton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor NumberedPanel
2 participants
@mavarius @alexpaxton