Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: use empty state in ResourceList.Body when children is boolean false #422

Merged
merged 1 commit into from
Dec 23, 2019
Merged

fix: use empty state in ResourceList.Body when children is boolean false #422

merged 1 commit into from
Dec 23, 2019

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented Dec 20, 2019 •
edited
Loading

Closes #421

Changes

When ResourceList.Body receives boolean false for its children, then it should render the empty state rather than a blank.

Screenshots

image

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved

@TCL735 TCL735 force-pushed the fix_421_empty_state_when_false branch from 38aac00 to 72a4ac9 Compare December 20, 2019 01:58
alexpaxton
alexpaxton approved these changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TCL735 TCL735 merged commit b83ec02 into master Dec 23, 2019
@TCL735 TCL735 deleted the fix_421_empty_state_when_false branch December 23, 2019 22:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexpaxton alexpaxton alexpaxton approved these changes

@121watts 121watts 121watts approved these changes

@mavarius mavarius Awaiting requested review from mavarius mavarius is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResourceList.Body should use the empty state when children is boolean false
3 participants
@TCL735 @alexpaxton @121watts