Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(clockface): add VisibilityInput component #431

Merged
merged 2 commits into from
Jan 16, 2020
Merged

feat(clockface): add VisibilityInput component #431

merged 2 commits into from
Jan 16, 2020

Conversation

mavarius
Copy link
Collaborator

@mavarius mavarius commented Jan 16, 2020 •
edited
Loading

Closes #429

Changes

  • Add VisibilityInput composed version of Input component.
  • Add support for children prop in Input component

Screenshots

image
image

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved

@mavarius mavarius requested a review from asalem1 January 16, 2020 23:32
asalem1
asalem1 approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@asalem1 asalem1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can't wait to use it

@mavarius mavarius merged commit a866c6b into master Jan 16, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@asalem1 asalem1 asalem1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input Icons Clickable
2 participants
@mavarius @asalem1