Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: export variables.scss as a plain scss file for import #436

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

hoorayimhelping
Copy link
Contributor

@hoorayimhelping hoorayimhelping commented Feb 21, 2020

Changes

Exports ours variables.scss file as a plain scss file so anything that depends on clockface can access its variables.

this would allow us to do something like the following in Influxdb or giraffe

@import "reset";
@import "@influxdata/clockface/dist/variables.scss";
@import "mixins";

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass

Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg yes!

Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow so little code for such big impact

@alexpaxton
Copy link
Contributor

@hoorayimhelping just throw an entry in the changelog and you're good! Might have to add a header for the newest version if there isn't one

@hoorayimhelping hoorayimhelping force-pushed the bs_export_variables_as_scss branch from 3568fcc to d1c4cb6 Compare February 21, 2020 22:18
@hoorayimhelping hoorayimhelping merged commit 926cba6 into master Feb 21, 2020
@hoorayimhelping hoorayimhelping deleted the bs_export_variables_as_scss branch February 21, 2020 22:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants