Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Polish Tabs Component #444

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Polish Tabs Component #444

merged 3 commits into from
Mar 6, 2020

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Mar 6, 2020 •
edited
Loading

Changes

  • Change size of active state indicator to scale proportionally to the height of the tab
  • Make tabs overall slightly taller
  • Add subtle rounding to active state indicator

Screenshots

tabs-sizing

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from mavarius March 6, 2020 19:37
mavarius
mavarius approved these changes Mar 6, 2020
View reviewed changes
Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on the floor() to prevent blur

@alexpaxton alexpaxton merged commit f88f7c5 into master Mar 6, 2020
@alexpaxton alexpaxton deleted the polish-tabs branch March 6, 2020 20:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mavarius mavarius mavarius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpaxton @mavarius